Skip to content

Add view support to the relational model API#19971

Merged
AndriySvyryd merged 1 commit intomasterfrom
Issue12846
Feb 20, 2020
Merged

Add view support to the relational model API#19971
AndriySvyryd merged 1 commit intomasterfrom
Issue12846

Conversation

@AndriySvyryd
Copy link
Copy Markdown
Member

Use the new model in the query pipeline

Fixes #12846

Comment thread src/EFCore.Relational/Metadata/Internal/TableBase.cs Outdated
Comment thread src/EFCore.Relational/Metadata/Internal/Column.cs Outdated
Comment thread src/EFCore.Relational/Metadata/Internal/RelationalModel.cs
new IViewColumn FindColumn([NotNull] string name);

/// <summary>
/// The view definition or <c>null</c> if this view is not managed by migrations.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting if you specify a view definition we will create it for you in migrations hence managed by migrations. :trollface:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the design...

Comment thread src/EFCore.Relational/Metadata/IViewMapping.cs
Comment thread src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs
Comment thread src/EFCore.Relational/Query/SqlExpressionFactory.cs
Copy link
Copy Markdown
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AndriySvyryd
Copy link
Copy Markdown
Member Author

AndriySvyryd commented Feb 20, 2020

@smitpatel @ajcvickers @bricelam I've reverted the breaking change to SnapshotModelProcessor

Use the new model in the query pipeline

Fixes #12846
/// <param name="property"> The property. </param>
/// <returns> The type mapping, or null if none was found. </returns>
[DebuggerStepThrough]
[Obsolete("Use FindRelationalTypeMapping")]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why obsolete?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a consistent relational model API

3 participants