Add option for specifying stored/virtual on computed columns#20540
Merged
Add option for specifying stored/virtual on computed columns#20540
Conversation
Member
|
For IConventionPropertyBuilder we should have two separate methods |
Member
Author
Thanks, done (HasComputedColumnIsStored is somewhat weird naming but consistent etc.) |
Member
|
IsStoredComputedColumn would be better IMO |
5233bc7 to
2f6ca83
Compare
Member
Author
|
Rebased on latest master (resolving conflicts with #20602), squashed and renamed HasComputedColumnIsStored->IsStoredComputedColumn |
AndriySvyryd
approved these changes
Apr 14, 2020
Member
AndriySvyryd
left a comment
There was a problem hiding this comment.
Also add validation for properties mapped to the same column
2f6ca83 to
d64e341
Compare
Member
Author
|
Thanks @AndriySvyryd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6682
Cross-database situation
Notes
ComputedColumnIsStoredannotation alongsideComputedColumnSql. @AndriySvyryd I know you prefer to merge annotations where possible for perf, but I'm hesitant to encode both SQL and other info in the same annotation string. We can change the annotation format to<IsStored>,<SQL>and identify old annotations not starting with true/false and a comma, but since SQL is arbitrary SQL it seems a bit dangerous.storedbool we could have a ComputedColumnType enum (Stored/Virtual), but this seems needless verbose/heavy.