Update references to ReferenceHandler based on recent renaming #21135
Conversation
Follow up to dotnet/runtime#37296 (comment) The property and the type ReferenceHandling were recently renamed to Referencehandler on dotnet/runtime#36829 Above PR was also ported to dotnet/runtime preview6 branch under dotnet/runtime#37296 therefore once this is into master, it should be ported to release/5.0-preview6 branch as well.
ajcvickers
left a comment
ajcvickers
left a comment
There was a problem hiding this comment.
Code change approved, but still need to hear from @dougbu on the build/dependencies.
|
@jozkee this repo has pinned all dotnet/runtime dependencies at 5.0.0-preview.3.20214.6 though the current is 5.0.0-preview.7.20303.11. I don't remember why there's even a weekly Maestro++ subscription since it can't do anything. @ajcvickers❔ |
|
@bricelam @smitpatel Any knowledge on pinning the runtime dependencies? |
|
Currently dependencies are pinned to preview3. I guess we should have updated to preview4 when we publicly released it. We can just combine it with preview5 release when it happens. For this particular PR, we don't need this change till we start depending on preview6 packages of our dependencies. Based on our current schedule that is suppose to happen when preview6 is released to public. Hence we can close this PR and keep it in mind when we update our dependencies. |
|
Suggest merging this commit into the branch for #21369. It won't pass without the latest dotnet/runtime bits. |
dougbu
changed the base branch from
master
to
darc-master-02066b90-5510-4fd1-b185-e16a1cd072c5
|
Did the simple thing and changed the base to be the dependency PR's branch. If validation works here, can "Squash and merge" here then use admin rights to get #21369 in without another validation. |
|
@jozkee @smitpatel looks like something is wrong still. Likely the dotnet/runtime bits in #21369 don't include the new APIs. Have builds been successful? |
|
Added bits from here in #21369 closing this. |
Follow up to dotnet/runtime#37296 (comment).
The property and the type ReferenceHandling were recently renamed to Referencehandler on dotnet/runtime#36829.
Above PR was also ported to dotnet/runtime preview6 branch under dotnet/runtime#37296 therefore once this is into master, it should be ported to release/5.0-preview6 branch as well.
I don't see the CI build failing because of the name missmatch; is EFCore using the latest bits from dotnet/runtime? cc @dougbu