Skip to content

Set max batch size for SQL Server#21704

Merged
1 commit merged intomasterfrom
Issue9270
Jul 20, 2020
Merged

Set max batch size for SQL Server#21704
1 commit merged intomasterfrom
Issue9270

Conversation

@AndriySvyryd
Copy link
Copy Markdown
Member

@AndriySvyryd AndriySvyryd commented Jul 20, 2020

Fixes #9270

@AndriySvyryd AndriySvyryd requested a review from a team July 20, 2020 22:37
@ghost
Copy link
Copy Markdown

ghost commented Jul 20, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Copy Markdown
Member Author

AndriySvyryd commented Jul 20, 2020

@msftbot Require 1 sign off

@ghost
Copy link
Copy Markdown

ghost commented Jul 20, 2020

Hello @AndriySvyryd!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

ralmsdeveloper
ralmsdeveloper reviewed Jul 20, 2020
View reviewed changes
Comment thread src/EFCore.SqlServer/Update/Internal/SqlServerModificationCommandBatch.cs
}

_maxBatchSize = Math.Min(maxBatchSize ?? int.MaxValue, MaxRowCount);
_maxBatchSize = Math.Min(maxBatchSize ?? 42, MaxRowCount);
Copy link
Copy Markdown
Contributor

@ralmsdeveloper ralmsdeveloper Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd how are you?

Just out of curiosity, any specific reason for reaching number 42?

it's just curiosity.

Copy link
Copy Markdown
Contributor

@ralmsdeveloper ralmsdeveloper Jul 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, now I looked at issue #9270

Copy link
Copy Markdown
Member Author

@AndriySvyryd AndriySvyryd Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, any specific reason for reaching number 42?

Only because it's the answer to the Ultimate Question of Life, the Universe, and Everything and it has better perf in common scenarios than the implicit default of ~2100

Copy link
Copy Markdown
Contributor

@ralmsdeveloper ralmsdeveloper Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u, living and learning!

@ghost ghost merged commit ffcb62d into master Jul 20, 2020
@ghost ghost deleted the Issue9270 branch July 20, 2020 23:43
@ajcvickers ajcvickers mentioned this pull request Jul 23, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ralmsdeveloper ralmsdeveloper ralmsdeveloper left review comments

@smitpatel smitpatel smitpatel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set a default max batch size for SQL Server

3 participants

@AndriySvyryd @smitpatel @ralmsdeveloper