Add a convention that builds a read-optimized model to be used at runtime by AndriySvyryd · Pull Request #24430 · dotnet/efcore

AndriySvyryd · 2021-03-18T00:25:20Z

Allow the design-time model to be accessed when necessary

Fixes #8258

smitpatel · 2021-03-18T03:25:37Z

Is there any specific reason, you individually added multiple people for review rather than the team? 🤔

AndriySvyryd · 2021-03-18T05:18:25Z

Is there any specific reason, you individually added multiple people for review rather than the team? 🤔

Yes, I want multiple reviews instead of a single one representing the team.

AndriySvyryd · 2021-03-19T22:48:56Z

+        object Create(DbContext context, bool designTime)
+#pragma warning disable CS0618 // Type or member is obsolete
+            => Create(context);
+#pragma warning restore CS0618 // Type or member is obsolete


@ajcvickers

AndriySvyryd · 2021-03-19T22:50:25Z

+                propertyCount += binding.ConsumedProperties.Count;
+            }
+
+            return new ObjectArrayParameterBinding(newBindings);


@ajcvickers

AndriySvyryd · 2021-03-19T22:50:58Z

                .AddTransient(_ => context.GetService<IMigrator>())
                .AddTransient(_ => context.GetService<IRelationalTypeMappingSource>())
-                .AddTransient(_ => context.GetService<IModel>())
+                .AddTransient(_ => context.DesignTimeModel)


@bricelam @ajcvickers

AndriySvyryd · 2021-03-19T22:52:08Z

+        public virtual IModel DesignTimeModel
+        {
+            [DebuggerStepThrough]
+            get => ContextServices.DesignTimeModel;


@ajcvickers

We can argue about naming later...

"argue" rather than "discuss"

AndriySvyryd · 2021-03-19T22:53:55Z

+                annotations[RelationalAnnotationNames.ViewName] = entityType.GetViewName();
+                annotations[RelationalAnnotationNames.ViewSchema] = entityType.GetViewSchema();
+                annotations[RelationalAnnotationNames.SqlQuery] = entityType.GetSqlQuery();
+                annotations[RelationalAnnotationNames.FunctionName] = entityType.GetFunctionName();


AndriySvyryd · 2021-03-19T22:54:43Z

+
+                        return model!;
+                    },
+                    model);


smitpatel

Allow the design-time model to be accessed when necessary Fixes #8258

ghost · 2021-03-23T21:52:10Z

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2021-03-23T21:52:13Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

Azure Pipelines
.NET Helix

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

ghost · 2021-03-23T22:18:36Z

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

.NET Helix

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

AndriySvyryd added providers-beware breaking-change labels Mar 18, 2021

AndriySvyryd requested review from ajcvickers, bricelam, maumar, roji and smitpatel March 18, 2021 00:25

AndriySvyryd commented Mar 19, 2021

View reviewed changes

Comment thread src/EFCore/Infrastructure/IModelRuntimeInitializer.cs

AndriySvyryd commented Mar 19, 2021

View reviewed changes

Comment thread src/EFCore.Relational/Storage/RelationalDatabaseCreator.cs

AndriySvyryd commented Mar 19, 2021

View reviewed changes

Comment thread src/EFCore.Relational/Metadata/Conventions/RelationalSlimModelConvention.cs

AndriySvyryd commented Mar 19, 2021

View reviewed changes

Comment thread src/EFCore/Infrastructure/ModelRuntimeInitializer.cs

return model!;

},

model);

Copy link
Copy Markdown

Member Author

AndriySvyryd Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roji

smitpatel reviewed Mar 22, 2021

View reviewed changes

Comment thread src/EFCore.Relational/Metadata/Conventions/RelationalSlimModelConvention.cs

smitpatel reviewed Mar 22, 2021

View reviewed changes

Comment thread src/EFCore.Relational/Metadata/Conventions/RelationalSlimModelConvention.cs

smitpatel approved these changes Mar 22, 2021

View reviewed changes

AndriySvyryd force-pushed the Issue8258_3 branch from d0a6925 to 36e3196 Compare March 22, 2021 18:29

bricelam approved these changes Mar 23, 2021

View reviewed changes

Comment thread src/EFCore.Relational/Migrations/HistoryRepository.cs

Comment thread test/EFCore.Relational.Specification.Tests/Migrations/MigrationsInfrastructureTestBase.cs Outdated

ajcvickers reviewed Mar 23, 2021

View reviewed changes

Comment thread src/EFCore.InMemory/Storage/Internal/InMemoryStore.cs

ajcvickers approved these changes Mar 23, 2021

View reviewed changes

Add a convention that builds a slim model to be used at runtime

c6fd7ce

Allow the design-time model to be accessed when necessary Fixes #8258

AndriySvyryd force-pushed the Issue8258_3 branch from 36e3196 to c6fd7ce Compare March 23, 2021 21:22

AndriySvyryd added the auto-merge label Mar 23, 2021

AndriySvyryd merged commit 4722fe3 into main Mar 23, 2021

AndriySvyryd deleted the Issue8258_3 branch March 23, 2021 22:26

ajcvickers mentioned this pull request Mar 25, 2021

Entity Framework Biweekly Status Updates (2021) #23884

Closed

Conversation

AndriySvyryd commented Mar 18, 2021

Uh oh!

smitpatel commented Mar 18, 2021

Uh oh!

AndriySvyryd commented Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smitpatel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 23, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

ghost commented Mar 23, 2021

From the bot dev team

Uh oh!

ghost commented Mar 23, 2021

From the bot dev team

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AndriySvyryd commented Mar 18, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.