Skip to content

Obsolete MemberIdentity.IsNone() #24437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Mar 18, 2021
Merged

Obsolete MemberIdentity.IsNone() #24437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/EFCore/Metadata/Internal/InternalForeignKeyBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3309,9 +3309,7 @@ private InternalForeignKeyBuilder MergeFacetsFrom(Navigation newNavigation, Navi

if (configurationSource != ConfigurationSource.Explicit
&& (shouldResetToPrincipal || shouldResetToDependent)
&& (navigationToPrincipal == null
|| navigationToPrincipal.Value.IsNone()
|| navigationToDependent?.IsNone() != false)
&& (navigationToPrincipal?.Name is null || navigationToDependent?.Name is null)
&& candidateRelationship.Metadata.DependentToPrincipal != null
&& candidateRelationship.Metadata.PrincipalToDependent != null
&& ((!candidateRelationshipInverted
Expand Down
3 changes: 3 additions & 0 deletions src/EFCore/Metadata/MemberIdentity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Reflection;

namespace Microsoft.EntityFrameworkCore.Metadata
Expand Down Expand Up @@ -46,6 +47,8 @@ private MemberIdentity(object? nameOrMember)
/// Checks if the identity is empty, as opposed to representing a member.
/// </summary>
/// <returns> <see langword="true" /> if the identity is empty; <see langword="false" /> otherwise. </returns>
[Obsolete("Compare Name to null")]
[MemberNotNullWhen(false, nameof(Name))]
public bool IsNone()
=> _nameOrMember == null;

Expand Down