Conversation
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
maumar
commented
Apr 1, 2021
AndriySvyryd
reviewed
Apr 1, 2021
Member
|
You should also include the model snapshot changes ( |
AndriySvyryd
reviewed
Apr 1, 2021
bricelam
reviewed
Apr 2, 2021
Contributor
bricelam
left a comment
bricelam
left a comment
There was a problem hiding this comment.
LGTM. (I skimmed through the Migrations and Scaffolding code)
maumar
force-pushed
the
temporal_tables_draft1
branch
from
fa19711 to
53b9708
Compare
maumar
commented
Apr 12, 2021
maumar
commented
Apr 12, 2021
maumar
commented
Apr 12, 2021
maumar
force-pushed
the
temporal_tables_draft1
branch
from
53b9708 to
c3e9c6c
Compare
maumar
commented
Apr 12, 2021
maumar
force-pushed
the
temporal_tables_draft1
branch
from
c3e9c6c to
ee6ccc0
Compare
maumar
commented
Apr 12, 2021
maumar
commented
Apr 12, 2021
maumar
commented
Apr 12, 2021
maumar
commented
Apr 12, 2021
maumar
force-pushed
the
temporal_tables_draft1
branch
from
ee6ccc0 to
f046c3c
Compare
bricelam
reviewed
Apr 13, 2021
maumar
force-pushed
the
temporal_tables_draft1
branch
from
dbf4630 to
6855940
Compare
Contributor
Author
|
new version up @AndriySvyryd @bricelam @smitpatel |
maumar
force-pushed
the
temporal_tables_draft1
branch
from
6855940 to
0f42aa8
Compare
maumar
force-pushed
the
temporal_tables_draft1
branch
from
0f42aa8 to
351e8a2
Compare
AndriySvyryd
reviewed
Jun 2, 2021
AndriySvyryd
reviewed
Jun 2, 2021
AndriySvyryd
reviewed
Jun 2, 2021
maumar
force-pushed
the
temporal_tables_draft1
branch
3 times, most recently
from
7461ef5 to
b7e49cb
Compare
AndriySvyryd
approved these changes
Jun 2, 2021
- added model builder APIs that allows mapping entity to a temporal table as well as related configuration - added conventions and validation for entities mapped to temporal table - added migration support for adding/removing/modifying entities mapped to a temporal table - added model snapshot generation for entities mapped to temporal table
maumar
force-pushed
the
temporal_tables_draft1
branch
from
b7e49cb to
e7c0b9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now just metadata and create+ drop migration operations