Conversation
|
Ugg. More OData failures. |
|
@ajcvickers Looks like there are binary breaking changes in Logging: 😕
|
Additional changes made to skip OData tests
test/EFCore.OData.FunctionalTests/Properties/TestAssemblyConditions.cs
Outdated
Show resolved
Hide resolved
This is a known issue though the breadth of the change is pretty annoying. Fix is private static readonly LogDefineOptions SkipEnabledCheckLogOptions = new() { SkipEnabledCheck = true };`
...
_generatedCodeToAssemblyCompilationEnd = LoggerMessage.Define<string, double>(
LogLevel.Annoyance,
2,
"...",
SkipEnabledCheckLogOptions);See also @TanayParikh's work in dotnet/aspnetcore#34033 and the actual break in dotnet/runtime#54581. |
…0718.2 (dotnet#25288) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0719.8 (dotnet#25290) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0720.7 (dotnet#25298) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0720.12 (dotnet#25299) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0720.18 (dotnet#25301) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0721.11 (dotnet#25312) [release/6.0-preview7] Update dependencies from dotnet/runtime
…t#25316) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0722.16 (dotnet#25317) [release/6.0-preview7] Update dependencies from dotnet/runtime
…722.16 (dotnet#25326) [release/6.0-preview7] Update dependencies from dotnet/arcade
…0723.17 (dotnet#25328) [release/6.0-preview7] Update dependencies from dotnet/runtime
…tensions.Logging (dotnet#25324) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Andriy Svyryd <Andriy.Svyryd@microsoft.com>
|
So, the problem with that approach is that we don't own the code with |
|
Upgrading to Preview 7 resolves this, but brings other breaking changes, see #25324 |
|
Yuck. Our branches are getting messy with one-offs in preview 6 and preview 7. |
We should wait until dotnet/roslyn#55114 is fixed and then jump to rc1. If it's not fixed in rc1, then we'll need to have a discussion. |
…t#25338) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0727.4 (dotnet#25341) [release/6.0-preview7] Update dependencies from dotnet/runtime
…0727.12 (dotnet#25342) Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Logging , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.DependencyModel , System.Collections.Immutable , System.Diagnostics.DiagnosticSource From Version 6.0.0-preview.7.21377.4 -> To Version 6.0.0-preview.7.21377.12 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…0727.19 (dotnet#25353) [release/6.0-preview7] Update dependencies from dotnet/runtime
|
@AndriySvyryd It looks like the latest daily build of the Preview 7 SDK has it. (Or at least my local build seems to have passed.) Can you review to make sure I didn't keep anything from #25324 that we don't want in |
Resolves #25148