Skip to content

Support SQL Server UTF8 strings#27634

Merged
roji merged 4 commits intodotnet:mainfrom
roji:SqlServerUTF8
Mar 17, 2022
Merged

Support SQL Server UTF8 strings#27634
roji merged 4 commits intodotnet:mainfrom
roji:SqlServerUTF8

Conversation

@roji
Copy link
Copy Markdown
Member

@roji roji commented Mar 13, 2022

Closes #25798

@roji roji requested a review from a team March 13, 2022 12:55
Copy link
Copy Markdown
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when test failures are fixed.

@roji
Copy link
Copy Markdown
Member Author

roji commented Mar 14, 2022

@ajcvickers did small product code fix, you may want to take another look.

@roji roji mentioned this pull request Mar 16, 2022
@roji
Copy link
Copy Markdown
Member Author

roji commented Mar 16, 2022

Tests failing in the Windows build because of an older version of SQL Server (2019 is required), see #27650

@roji roji merged commit 587de30 into dotnet:main Mar 17, 2022
@roji roji deleted the SqlServerUTF8 branch March 17, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Server UTF8 collations

2 participants