Skip to content

Use DbType.Currency for money parameters #29048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajcvickers wants to merge 1 commit into from
Closed

Use DbType.Currency for money parameters #29048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.SqlServer/Storage/Internal/SqlServerTypeMappingSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ private readonly DecimalTypeMapping _decimal182
= new SqlServerDecimalTypeMapping("decimal(18, 2)", precision: 18, scale: 2);

private readonly DecimalTypeMapping _money
= new SqlServerDecimalTypeMapping("money", storeTypePostfix: StoreTypePostfix.None);
= new SqlServerDecimalTypeMapping("money", DbType.Currency, storeTypePostfix: StoreTypePostfix.None);

private readonly TimeSpanTypeMapping _time
= new SqlServerTimeSpanTypeMapping("time");
Expand Down
28 changes: 14 additions & 14 deletions test/EFCore.SqlServer.FunctionalTests/BuiltInDataTypesSqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,9 +670,9 @@ public virtual void Can_insert_and_read_back_all_mapped_data_types()
@p19='2016-01-02T11:11:12.1234567+00:00'
@p20='101.1' (Precision = 4) (Scale = 1)
@p21='102.2' (Precision = 4) (Scale = 1)
@p22='81.1' (Precision = 3) (Scale = 1)
@p22='81.1' (DbType = Currency)
@p23='103.3' (Precision = 4) (Scale = 1)
@p24='82.2' (Precision = 3) (Scale = 1)
@p24='82.2' (DbType = Currency)
@p25='85.5'
@p26='83.3'
@p27='Value4' (Nullable = false) (Size = 20)
Expand Down Expand Up @@ -873,9 +873,9 @@ public virtual void Can_insert_and_read_back_all_mapped_data_types_with_square_b
@p14='2016-01-02T11:11:12.1234567+00:00'
@p15='101.1' (Precision = 4) (Scale = 1)
@p16='102.2' (Precision = 4) (Scale = 1)
@p17='81.1' (Precision = 3) (Scale = 1)
@p17='81.1' (DbType = Currency)
@p18='103.3' (Precision = 4) (Scale = 1)
@p19='82.2' (Precision = 3) (Scale = 1)
@p19='82.2' (DbType = Currency)
@p20='83.3'
@p21='Value4' (Nullable = false) (Size = 20)
@p22='Value2' (Nullable = false) (Size = 8000) (DbType = AnsiString)
Expand Down Expand Up @@ -1041,9 +1041,9 @@ public virtual void Can_insert_and_read_back_all_mapped_nullable_data_types()
@p19='2016-01-02T11:11:12.9876543+00:00' (Nullable = true)
@p20='101.1' (Nullable = true) (Precision = 4) (Scale = 1)
@p21='102.2' (Nullable = true) (Precision = 4) (Scale = 1)
@p22='81.1' (Nullable = true) (Precision = 3) (Scale = 1)
@p22='81.1' (Nullable = true) (DbType = Currency)
@p23='103.3' (Nullable = true) (Precision = 4) (Scale = 1)
@p24='82.2' (Nullable = true) (Precision = 3) (Scale = 1)
@p24='82.2' (Nullable = true) (DbType = Currency)
@p25='85.5' (Nullable = true)
@p26='83.3' (Nullable = true)
@p27='Value4' (Size = 20)
Expand Down Expand Up @@ -1235,9 +1235,9 @@ public virtual void Can_insert_and_read_back_all_mapped_data_types_set_to_null()
@p19=NULL (DbType = DateTimeOffset)
@p20=NULL (DbType = Decimal)
@p21=NULL (DbType = Decimal)
@p22=NULL (DbType = Decimal)
@p22=NULL (DbType = Currency)
@p23=NULL (DbType = Decimal)
@p24=NULL (DbType = Decimal)
@p24=NULL (DbType = Currency)
@p25=NULL (DbType = Double)
@p26=NULL (DbType = Double)
@p27=NULL (Size = 20)
Expand Down Expand Up @@ -1898,9 +1898,9 @@ public virtual void Can_insert_and_read_back_all_mapped_data_types_with_identity
@p18='2016-01-02T11:11:12.7654321+00:00'
@p19='101.1' (Precision = 4) (Scale = 1)
@p20='102.2' (Precision = 4) (Scale = 1)
@p21='81.1' (Precision = 3) (Scale = 1)
@p21='81.1' (DbType = Currency)
@p22='103.3' (Precision = 4) (Scale = 1)
@p23='82.2' (Precision = 3) (Scale = 1)
@p23='82.2' (DbType = Currency)
@p24='85.5'
@p25='83.3'
@p26='Value4' (Nullable = false) (Size = 20)
Expand Down Expand Up @@ -2095,9 +2095,9 @@ public virtual void Can_insert_and_read_back_all_mapped_nullable_data_types_with
@p18='2016-01-02T11:11:12.2345678+00:00' (Nullable = true)
@p19='101.1' (Nullable = true) (Precision = 4) (Scale = 1)
@p20='102.2' (Nullable = true) (Precision = 4) (Scale = 1)
@p21='81.1' (Nullable = true) (Precision = 3) (Scale = 1)
@p21='81.1' (Nullable = true) (DbType = Currency)
@p22='103.3' (Nullable = true) (Precision = 4) (Scale = 1)
@p23='82.2' (Nullable = true) (Precision = 3) (Scale = 1)
@p23='82.2' (Nullable = true) (DbType = Currency)
@p24='85.5' (Nullable = true)
@p25='83.3' (Nullable = true)
@p26='Value4' (Size = 20)
Expand Down Expand Up @@ -2289,9 +2289,9 @@ public virtual void Can_insert_and_read_back_all_mapped_data_types_set_to_null_w
@p18=NULL (DbType = DateTimeOffset)
@p19=NULL (DbType = Decimal)
@p20=NULL (DbType = Decimal)
@p21=NULL (DbType = Decimal)
@p21=NULL (DbType = Currency)
@p22=NULL (DbType = Decimal)
@p23=NULL (DbType = Decimal)
@p23=NULL (DbType = Currency)
@p24=NULL (DbType = Double)
@p25=NULL (DbType = Double)
@p26=NULL (Size = 20)
Expand Down