Skip to content

Allow to ignore attributes when finding type mapping#32193

Merged
AndriySvyryd merged 1 commit intomainfrom
Issue11124
Nov 2, 2023
Merged

Allow to ignore attributes when finding type mapping#32193
AndriySvyryd merged 1 commit intomainfrom
Issue11124

Conversation

@AndriySvyryd
Copy link
Copy Markdown
Member

Make existing model building conventions more extensible

Fixes #11124
Fixes #28866

@AndriySvyryd AndriySvyryd requested a review from a team October 31, 2023 00:45
Allow to ignore attributes when finding type mapping

Fixes #11124
Fixes #28866
}

/// <inheritdoc/>
public override RelationalTypeMapping? FindMapping(MemberInfo member, IModel model, bool useAttributes)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might providers need to react to this? @roji @lauxjpn

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't override any of these FindMapping overloads (which accept MemberInfo) in Npgsql, only the version which accepts RelationalTypeMappingInfo... That should be OK, right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make existing model building conventions more extensible Move detection of ColumnAttribute in RelationalTypeMappingInfo to conventions

3 participants