Handle updating complex type properties in ExecuteUpdate#32499
Merged
roji merged 2 commits intodotnet:mainfrom Jan 11, 2024
Merged
Handle updating complex type properties in ExecuteUpdate#32499roji merged 2 commits intodotnet:mainfrom
roji merged 2 commits intodotnet:mainfrom
Conversation
No actual code change
roji
changed the title
roji
force-pushed
the
ExecuteUpdateComplexType
branch
from
4556993 to
622fe47
Compare
roji
force-pushed
the
ExecuteUpdateComplexType
branch
from
622fe47 to
13bb7d2
Compare
Member
Author
|
Just a reminder that this is still waiting for a review. |
ajcvickers
approved these changes
Jan 11, 2024
Contributor
ajcvickers
left a comment
ajcvickers
left a comment
There was a problem hiding this comment.
I can't pretend that I have a good understanding here, but from what I can tell, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ths 1st commit in this PR separates out the ExecuteDelete/Update code into separate partial files - no actual change there; so review only the 2nd commit.
This adds support for referencing complex types in ExecuteUpdate's property selector (e.g.
context.Customers.ExecuteUpdate(setters => setters.SetProperty(c => c.ShippingAddress, c => c.BillingAddress))). It also does various refactoring/cleanup that simplifies the code, and has a bit of preparation to JSON complex types.Closes #32058