Skip to content

Update developer docs for building packages and using developer build config#32597

Merged
ajcvickers merged 1 commit intomainfrom
231212_PackageMe
Dec 15, 2023
Merged

Update developer docs for building packages and using developer build config#32597
ajcvickers merged 1 commit intomainfrom
231212_PackageMe

Conversation

@ajcvickers
Copy link
Copy Markdown
Contributor

Fixes #25278
Fixes #19814
Fixes #27527

@ajcvickers ajcvickers requested a review from a team December 12, 2023 13:38
@ErikEJ
Copy link
Copy Markdown
Contributor

ErikEJ commented Dec 12, 2023

Thanks so much, this is very helpful!

Does all tests currently pass on an international machine? Or would you like me to check?

@ajcvickers
Copy link
Copy Markdown
Contributor Author

@ErikEJ I haven't tested that for a long time, so by all means go ahead!

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread docs/getting-and-building-the-code.md Outdated
@ErikEJ
Copy link
Copy Markdown
Contributor

ErikEJ commented Dec 12, 2023

@ajcvickers it is not good, I am in the process of updating #22901

Maybe at least add a note about this in the build guide? And maybe leave as is, closing #22901?

It is quite confusing for new contributors trying to run the tests locally - was it my changes or??

@ajcvickers ajcvickers merged commit 8d78860 into main Dec 15, 2023
@ajcvickers ajcvickers deleted the 231212_PackageMe branch December 15, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants