Sunday cleanup project: replace internal usage analyzer with [Experimental]

src/EFCore.Abstractions/ChangeTracking/Internal/ObservableBackedBindingList.cs

@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Specialized;
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Utilities;
 
 namespace Microsoft.EntityFrameworkCore.ChangeTracking.Internal;

src/EFCore.Abstractions/ChangeTracking/Internal/SortableBindingList.cs

@@ -3,7 +3,6 @@
 
 using System.Collections;
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 
 namespace Microsoft.EntityFrameworkCore.ChangeTracking.Internal;
 

src/EFCore.Abstractions/ChangeTracking/ObservableCollectionListSource.cs

@@ -4,7 +4,6 @@
 using System.Collections;
 using System.Collections.ObjectModel;
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 
 namespace Microsoft.EntityFrameworkCore.ChangeTracking;
 

src/EFCore.Abstractions/DbFunctionAttribute.cs

@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Utilities;
 
 namespace Microsoft.EntityFrameworkCore;

src/EFCore.Abstractions/EFCore.Abstractions.csproj

@@ -13,6 +13,7 @@
 
   <ItemGroup>
     <Using Include="System.Diagnostics" />
+    <Using Include="System.Diagnostics.CodeAnalysis" />
     <Using Include="System.Linq.Expressions" />
     <Using Include="System.Reflection" />
     <Using Include="Microsoft.EntityFrameworkCore" />

src/EFCore.Abstractions/EntityTypeConfigurationAttribute.cs

@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Utilities;
 
 namespace Microsoft.EntityFrameworkCore;

src/EFCore.Abstractions/IndexAttribute.cs

@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.Utilities;
 
 namespace Microsoft.EntityFrameworkCore;

src/EFCore.Abstractions/ObservableCollectionExtensions.cs

@@ -3,7 +3,6 @@
 
 using System.Collections.ObjectModel;
 using System.ComponentModel;
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.EntityFrameworkCore.ChangeTracking.Internal;
 
 namespace Microsoft.EntityFrameworkCore;

src/EFCore.Analyzers/AnalyzerReleases.Unshipped.md

@@ -0,0 +1,4 @@
+### Removed Rules
+Rule ID | Category | Severity | Notes
+--------|----------|----------|--------------------
+EF1001  | Usage    | Warning  |

src/EFCore.Analyzers/EFDiagnostics.cs

@@ -0,0 +1,20 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore;
+
+/// <summary>
+///     Contains IDs of diagnostics created by EF analyzers and other mechanisms.
+/// </summary>
+public static class EFDiagnostics
+{
+    public const string InterpolatedStringUsageInRawQueries = "EF1002";
+    public const string SuppressUninitializedDbSetRule = "EFSPR1001";
+
+    // Internal API usage
+    public const string CoreInternalUsage = "EF9901";
+    public const string RelationalInternalUsage = "EF9902";
+    public const string DesignInternalUsage = "EF9903";
+    public const string ProxiesInternalUsage = "EF9904";
+    public const string ProviderInternalUsage = "EF9999";
+}