Fixes #20604 - Treat ToString as casting to string in the database

[Danevandy99]

Fixes #20604

• I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• The code builds and tests pass locally (also verified by our automated build checks)
• Commit messages follow this format:

        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

• Tests for the changes have been added (for bug fixes / features)
• Code follows the same patterns and style as existing code in this repo

[Danevandy99]

The build Helix task seems to be stuck, but I'm not sure how to fix that.

[cincuranet]

LGTM, but maybe @roji sees something that I don't.

[roji]

The changes look OK, but I'm still a bit unsure as to the general utility of allowing ToString() for enums, which get mapped to integers by default in the database... In other words, this probably is useful only when value-converting the enum to string (which may be OK).

If we really want to allow arbitrary ToString() on anything - regardless of value conversion - we may as well just always ToString(), regardless of the CLR type or anything else (i.e. why limit just to enums?). Otherwise we may want to think a bit more generally before doing this.

Maybe let's discuss this in design today?

[Danevandy99]

@roji #33706 adds functionality that makes ToString on enums more useful when the enum is mapped to an int in the database.

[roji]

Yeah, I see - it's just that we probably need to discuss a broader strategy here when it comes to ToString, value conversion, etc. beyond just the enum case.

[Danevandy99]

Merging changes with #33706