TrimStart and TrimEnd with optional char array implementation for SQL Server

[abdielcs]

Fixes #22924

• [X ] I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• [ X] The code builds and tests pass locally (also verified by our automated build checks)
• [X ] Commit messages follow this format:

        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

• [X ] Tests for the changes have been added (for bug fixes / features)
• [X ] Code follows the same patterns and style as existing code in this repo

[abdielcs]

@dotnet-policy-service agree

[roji]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[cincuranet]

@maumar or @roji can I get 2nd set of eyes. Otherwise LGTM.

[roji]

Thanks, here are some comments from me.

Note that there's also #22927 for Trim (as opposed to TrimStart/End) - it would be good to add this translation too (though it doesn't have to happen in the same PR).

[abdielcs]

Thanks, here are some comments from me.

Note that there's also #22927 for Trim (as opposed to TrimStart/End) - it would be good to add this translation too (though it doesn't have to happen in the same PR).

Yes, I saw the Trim, but since it has a different syntax in the new version, it is unlikely that it can be done in the same way. So, @roji, if you agree, I would prefer to address it after finishing these.

For some reason, my SQLite tests are failing again. Maybe I'm doing something wrong in the merge or something?

[azure-pipelines]

Commenter does not have sufficient privileges for PR 33715 in repo dotnet/efcore

[cincuranet]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[roji]

Thanks, this is very close - see note below. I'll just go ahead and fix the remaining issue plus some cleanup.

Thanks for your contribution!

[roji]

It's a bit of an annoying little detail, but the previous code did translate TrimStartMethodInfoWithCharArrayArg as long as the first argument is an empty array constant. I don't think it was an important thing to do, but once it's there I don't think we should be removing it (it's a very minor but also needless breaking change). So can we please preserve the previous behavior, and only put the new translation inside the CompatibilityLevel condition?