Fix and enable Bitwise_and_on_expression_with_like_and_null_check_being_compared_to_false#33872
Merged
maumar merged 2 commits intodotnet:mainfrom Jun 3, 2024
Merged
Fix and enable Bitwise_and_on_expression_with_like_and_null_check_being_compared_to_false#33872maumar merged 2 commits intodotnet:mainfrom
Bitwise_and_on_expression_with_like_and_null_check_being_compared_to_false#33872maumar merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
now that #33873 is in, the baselines need to be updated. But when that's done we are good to go here. |
…ing_compared_to_false` The result ordering needs to be consistent; apart from that, the test already passes.
After dotnet#33873 EFCore emits different queries for the test.
Contributor
Author
|
@maumar I rebased on top of main and regenerated the baselines (and I like the new ones better, especially for SQL Server 😉 ). |
maumar
approved these changes
Jun 3, 2024
Contributor
|
thanks for the cleanup @ranma42 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result ordering needs to be consistent; apart from that, the test already passes.