Cosmos: use ReadItem for more Find cases#33896
Merged
ajcvickers merged 1 commit intomainfrom Jun 5, 2024
Merged
Conversation
AndriySvyryd
reviewed
Jun 5, 2024
| QueryCompilationContext.QueryTrackingBehavior == QueryTrackingBehavior.NoTrackingWithIdentityResolution), | ||
| Constant(_threadSafetyChecksEnabled)); | ||
| var cosmosQueryContextConstant = Convert(QueryCompilationContext.QueryContextParameter, typeof(CosmosQueryContext)); | ||
| var shaperConstant = Constant(shaperLambda.Compile()); |
Member
There was a problem hiding this comment.
I think we'd need to move out this Compile() to make Cosmos compatible with pre-compiled queries.
@roji De we have a separate issue tracking this work?
Member
There was a problem hiding this comment.
Nope, opened #33909 to track Cosmos NativeAOT support.
AndriySvyryd
approved these changes
Jun 5, 2024
This change stops using `ReadItemExpression`, since it does not do any shaper processing, and instead uses `SelectExpression` as for other queries. This allows processing of auto-Includes for owned types, even if Find is being translated to `ReadItem`. This is somewhat hacky now, but it likely to change again as the processing for Includes and/or complex types is changed. For now, it's a reasonable way to get an important feature working. Fixes #24202 In addition, the pattern matching has been updated to detect calls to non-generic Find. Fixes #33881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change stops using
ReadItemExpression, since it does not do any shaper processing, and instead usesSelectExpressionas for other queries. This allows processing of auto-Includes for owned types, even if Find is being translated toReadItem.This is somewhat hacky now, but it likely to change again as the processing for Includes and/or complex types is changed. For now, it's a reasonable way to get an important feature working.
Fixes #24202
In addition, the pattern matching has been updated to detect calls to non-generic Find.
Fixes #33881