Clean up container management in Cosmos#33898
Merged
roji merged 1 commit intodotnet:mainfrom Jun 5, 2024
Merged
Conversation
AndriySvyryd
approved these changes
Jun 5, 2024
roji
force-pushed
the
RemoveContainerFromSelect
branch
from
ee967c1 to
b3d5982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is based on top of #33895, review 2nd commit onlyThe Cosmos container is currently extracted from the entity type and stored inside SelectExpression - but it doesn't belong there. For one thing, there can be multiple SelectExpressions in a single query (e.g. subqueries), but queries can only ever reference a single container. There was also some hacky stuff around owned entities, which aren't considered to have a (direct) container, but SelectExpression required one.
Removed the container concept from SelectExpression altogether, and moved it to CosmosQueryCompilationContext (which is scoped to the entire query) - like the partition key.