Fix UpdateExpression.VisitChildren to visit the setter column#33948
Merged
roji merged 1 commit intodotnet:mainfrom Jun 11, 2024
Merged
Fix UpdateExpression.VisitChildren to visit the setter column#33948roji merged 1 commit intodotnet:mainfrom
roji merged 1 commit intodotnet:mainfrom
Conversation
maumar
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem here was a bug in UpdateExpression.VisitChildren: for column setters, it was visiting the values but not the columns. In 9.0, our alias post-processing logic now replaces columns in the entire tree when rewriting aliases, but the columns inside UpdateExpression weren't being changed because of this, causing incorrect SQL.
Fixes #33937