Improve some null-related tests#34019
Merged
maumar merged 5 commits intodotnet:mainfrom Jun 18, 2024
Merged
Conversation
This change aims at ensuring that the expressions within the queries being tested cannot be trivially optimized away. Based on the suggestion by @maumar in dotnet#33938 (comment)
The property type is `bool?`, not `bool`.
The new dataset shows that the current implementation does not actually behave as intended (aka as expected by the test).
This was referenced Jun 18, 2024
maumar
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves some tests. Specifically:
COALESCEoperations cannot be trivially optimized awaynullin theEradicatedfieldBecause of the changes, it regresses some tests. They are handled as follows:
Property_access_on_derived_entity_using_castis fixed by using the appropriate typingToString_boolean_property_nullableis marked as skipped because of the issue Inconsistent results forNullable<bool>.ToString()#33941