Introduce UseAzureSynapse and UseAzureSql by cincuranet · Pull Request #34052 · dotnet/efcore

cincuranet · 2024-06-21T11:53:29Z

AndriySvyryd · 2024-07-11T18:00:42Z

@cincuranet Let me know once this is ready for review again

cincuranet · 2024-07-17T11:08:56Z

@AndriySvyryd This should be now ready for review.

AndriySvyryd · 2024-08-06T23:45:35Z

Looking at this again I find it confusing that you can call .UseSqlServer(b => UseAzureSqlCompatibilityLevel())
Each of the Use* methods should accept a different builder type, then they each could just have a UseCompatibilityLevel method that corresponds to the target engine.
Additionally, for ConfigureSqlEngine the builder should have a non-obsolete method that enables a retrying execution strategy if one wasn't configured (I don't remember what we decided to name this)

cincuranet changed the title ~~Synapse~~ Introduce UseAzureSynapse and UseAzureSql Jun 21, 2024

cincuranet marked this pull request as ready for review June 25, 2024 17:57

cincuranet requested a review from a team June 25, 2024 17:57

AndriySvyryd reviewed Jun 25, 2024

View reviewed changes

Comment thread src/EFCore.SqlServer/Extensions/AzureSqlDbContextOptionsBuilderExtensions.cs Outdated

AndriySvyryd reviewed Jun 25, 2024

View reviewed changes

Comment thread src/EFCore.SqlServer/Extensions/AzureSynapseDbContextOptionsBuilderExtensions.cs Outdated

AndriySvyryd reviewed Jun 25, 2024

View reviewed changes

Comment thread test/EFCore.SqlServer.FunctionalTests/SqlServerConfigPatternsTest.cs

AndriySvyryd reviewed Jun 25, 2024

View reviewed changes

Comment thread src/EFCore.SqlServer/Extensions/AzureSqlServiceCollectionExtensions .cs Outdated

AndriySvyryd reviewed Jun 25, 2024

View reviewed changes

Comment thread src/EFCore.SqlServer/Query/Internal/SqlServerQueryableMethodTranslatingExpressionVisitor.cs Outdated

Implement UseAzureSql/UseAzureSynapse.

e23ac06

cincuranet requested a review from AndriySvyryd July 17, 2024 11:08