Generate suppressible error when entity saved to Cosmos without PK value set#34250
Merged
ajcvickers merged 2 commits intomainfrom Jul 22, 2024
Merged
Generate suppressible error when entity saved to Cosmos without PK value set#34250ajcvickers merged 2 commits intomainfrom
ajcvickers merged 2 commits intomainfrom
Conversation
roji
approved these changes
Jul 21, 2024
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
See mainly simple implementation notes
…lue set Fixes #34180 We throw if there is no property in the primary key that is not generated and does not have a value set, excluding partition key properties.
ajcvickers
force-pushed
the
HotFridayDeals
branch
from
ccbe877 to
a1a643e
Compare
roji
reviewed
Jul 21, 2024
ajcvickers
force-pushed
the
HotFridayDeals
branch
from
a1a643e to
78cb544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34180
We throw if there is no property in the primary key that is not generated and does not have a value set, excluding partition key properties.