Implement nullability simplification for COLLATE and AT TIME ZONE#34263
Merged
roji merged 6 commits intodotnet:mainfrom Jul 26, 2024
Merged
Implement nullability simplification for COLLATE and AT TIME ZONE#34263roji merged 6 commits intodotnet:mainfrom
COLLATE and AT TIME ZONE#34263roji merged 6 commits intodotnet:mainfrom
Conversation
It now handles `COLLATE` and `AT TIME ZONE`.
Contributor
Author
|
This was born out of @roji's comment here: #34127 (comment) Should I simply open a new issue covering |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
The Helix failure(s) is weird: |
Contributor
Author
|
I will need some guidance to reproduce the error locally. |
ranma42
commented
Jul 23, 2024
| select e.Id).ToList(); | ||
|
|
||
| var actual = (from e in context.Set<OperatorEntityNullableDateTimeOffset>() | ||
| where !((DateTimeOffset?)EF.Functions.AtTimeZone(e.Value.Value, "UTC")).HasValue |
Contributor
Author
There was a problem hiding this comment.
(unrelated to this PR)
this syntax looks convoluted and is fragile when combined with other operations
I was able to invoke EF.Functions.AtTimeZone on a DateTimeOffset? with .Value, but I was unable to convince the compiler that comparing its result to null was reasonable, even after a cast.
Specifically, the compiler rejects:
EF.Functions.AtTimeZone(e.Value.Value, "UTC") == null(which looks like the most natural way to perform this check in an expression, but is forbidden because on the C# side the result ofAtTimeZoneis a non-nullable value type)((DateTimeOffset?)EF.Functions.AtTimeZone(e.Value.Value, "UTC")) == null
💔
EDIT: mentioned that it is not a problem in the commits (but I would still love to express this more cleanly 😇 )
Contributor
There was a problem hiding this comment.
you can use pragma to work around compiler block:
var actual = (from e in context.Set<OperatorEntityNullableDateTimeOffset>()
#pragma warning disable CS8073 // The result of the expression is always the same since a value of this type is never equal to 'null'
where EF.Functions.AtTimeZone(e.Value.Value, "UTC") == null
#pragma warning restore CS8073 // The result of the expression is always the same since a value of this type is never equal to 'null'
select e.Id).ToList();
Contributor
Given that it reproduces only on Helix machines and not the rest, makes me believe that it's not going to be easy to reproduce it locally. :( |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@ranma42 Seems to be OK now. Phew. |
maumar
approved these changes
Jul 26, 2024
Instead of working around the compiler by casting the expression, simply suppress the compiler warning. Suggested by @maumar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset extends the simplification for
IS [NOT] NULLto handleCOLLATEandAT TIME ZONE.Closes #34295