New EF.Constant handling#34297
Merged
cincuranet merged 2 commits intodotnet:mainfrom Aug 11, 2024
cincuranet:ef-constant
Merged
New EF.Constant handling#34297cincuranet merged 2 commits intodotnet:mainfrom cincuranet:ef-constant
cincuranet merged 2 commits intodotnet:mainfrom
cincuranet:ef-constant
Conversation
roji
reviewed
Jul 26, 2024
roji
requested changes
Aug 2, 2024
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Really good first attempt @cincuranet, this covers many parts of the query pipeline and it's great to see all this work. See below for all my comments.
Note that it would be good to add some tests which cover the bugs in the current implementations (e.g. inline collection with a single scalar parameter, which shouldn't get treated as a "values parameter").
roji
reviewed
Aug 4, 2024
Contributor
Author
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
Author
|
@roji This is ready for another review pass. |
roji
approved these changes
Aug 8, 2024
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Almost LGTM, see only nits below 🎉
Can fix the nits, but please don't merge yet though - I want to take a look at the precompiled query code there.
roji
reviewed
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33674