[release/9.0] Fix type mapping management for JsonScalarExpression#34663
Merged
roji merged 1 commit intodotnet:release/9.0from Sep 12, 2024
Merged
[release/9.0] Fix type mapping management for JsonScalarExpression#34663roji merged 1 commit intodotnet:release/9.0from
roji merged 1 commit intodotnet:release/9.0from
Conversation
AndriySvyryd
approved these changes
Sep 12, 2024
2760589 to
d79ae8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33582
Description
In 8.0, EF started translating queries using scalar collections. Unfortunately, the type mapping inference for scalar collections (JsonScalarExpression specifically) was flawed, as various infra was missing at the time, and applied the default type mapping in cases where it shouldn't have. This PR fixes type mapping inference for JsonScalarExpression.
Customer impact
Queries using non-column scalar collections could fail in various scenarios. Example:
How found
Reported by user.
Regression
Yes - from 7.0 to 8.0.
The case in #33582 was previously being client-evaluated (top-level Select); the scalar collection support in 8.0 allowed this to get this translated, but then the translation got blocked by this bug.
Testing
Added.
Risk
Low.