Create table mappings for complex types in TPC #35314
Conversation
| var complexTypeTable = complexProperty.ComplexType.GetViewOrTableMappings().SingleOrDefault( | ||
| ctm => containerProjection.TableMap.ContainsKey(ctm.Table))?.Table; |
There was a problem hiding this comment.
@roji There can now be more than one mapping per complex type when all types in TPC hierarchy are selected. I think this code needs significant updates to support this. Do you see a simple/safe way to make it work for 9.0.x?
There was a problem hiding this comment.
Right, makes sense... I'd have to look deeper, but is PR as-is sufficient to make it work? If so it doesn't necessarily seem to bad for a patch?
BTW if things do get complicated here and we only fix this for 10 (as part of the big complex type push), I don't think it's the end of the world either...
There was a problem hiding this comment.
Right, makes sense... I'd have to look deeper, but is PR as-is sufficient to make it work? If so it doesn't necessarily seem to bad for a patch?
This PR changes the exception from "no elements" to "more than one element"
test/EFCore.Relational.Specification.Tests/Query/AdHocMiscellaneousQueryRelationalTestBase.cs
Outdated
Show resolved
Hide resolved
|
Superceded by #37410 |
Fixes #35025