Support Cosmos VectorDistance options and general cleanup #36448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Jul 27, 2025
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore.Cosmos.Extensions; | ||
| namespace Microsoft.EntityFrameworkCore; |
Member
Author
There was a problem hiding this comment.
Note this namespace change, which aligns our extensions class with the other providers - users shouldn't need to use a special namespace to get these extensions. While technically a breaking change, there were almost no methods here before 10 anyway (and none before 9), and it's quite unlikely to actually affect anyone...
| if (options is not null) | ||
| { | ||
| if (arguments[4] is not SqlConstantExpression { Value: DistanceFunction distanceFunction }) | ||
| // If the options are provided but not useBruteForce, we need to explicitly specify the default for the |
Member
Author
There was a problem hiding this comment.
This is somewhat unfortunate - we have to explicitly provide the default (false) when the options are specified and the user explicitly passes null to useBruteForce. But seems fine.
roji
force-pushed
the
CosmosVectorDistance
branch
from
0baea29 to
77a388e
Compare
AndriySvyryd
approved these changes
Jul 28, 2025
roji
force-pushed
the
CosmosVectorDistance
branch
from
77a388e to
fb76bde
Compare
Member
Author
|
Test failures are SQL Server flakiness, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36447
/cc @artl93