[rc2] Properly handle automatic rollbacks in SQLite in Commit.

[cincuranet]

Fixes #36561.

Description

Some SQLite errors can cause automatic rollback when errors (i.e. SQLITE_FULL) occur within a transaction. The way SqliteTransaction handles this case is incorrect.

Customer impact

Using using blocks with SqliteTransaction is difficult, because different - confusing - exception is thrown, hiding the original one.

How found

Customer reported on M.D.Sqlite 9.

Regression

No.

Testing

Manual testing.

Risk

Low.

[Copilot]

Pull Request Overview

This PR fixes improper handling of automatic rollbacks in SQLite transactions by reordering operations in the Commit() method. The issue occurs when SQLite errors (like SQLITE_FULL) cause automatic rollbacks during commit, leading to confusing exception messages when using using blocks with SqliteTransaction.

Key changes:

• Reorder the rollback hook clearing to occur after the commit operation
• Add explanatory comments about the timing of operations

[artl93]

RC2.
With this being SQLite, can we add a test for this?

[cincuranet]

@artl93 Adding tests for this is not easy/reliable. One options is to reliably create race condition between multiple threads writing, which I think is a recipe for flaky test. Or for SQLITE_FULL to have no free space on disk - easy to do locally manually - but I don't see an easy way to do it on CI. :(