Analyzer for string concatenation in raw SQL methods. #36698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
force-pushed
the
concat-analyzer
branch
from
19e7040 to
e296172
Compare
cincuranet
changed the title
cincuranet
force-pushed
the
concat-analyzer
branch
5 times, most recently
from
ef8427d to
a897c98
Compare
roji
approved these changes
Sep 9, 2025
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
LGTM after comments addressed, thanks!
src/EFCore.Analyzers/StringsUsageInRawQueriesDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Analyzers.Tests/StringsUsageInRawQueriesDiagnosticAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Analyzers.Tests/StringsUsageInRawQueriesDiagnosticAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Analyzers.Tests/StringsUsageInRawQueriesDiagnosticAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Analyzers.Tests/StringsUsageInRawQueriesDiagnosticAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
cincuranet
force-pushed
the
concat-analyzer
branch
from
a897c98 to
3fc2434
Compare
artl93
approved these changes
Sep 9, 2025
Member
artl93
left a comment
artl93
left a comment
There was a problem hiding this comment.
Approved. RC2. Breaking change?
roji
reviewed
Sep 9, 2025
Contributor
Author
|
@artl93 Not a breaking change. |
roji
reviewed
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35735.
Description
Doing string concatenation in raw SQL methods is dangerous, because it open possibility of SQL injection. We had analyzer for string interpolation, but not pure string concatenation. This fixed it.
Customer impact
Customers might be unknowingly open to SQL injection attacks.
How found
Customer reported.
Regression
No.
Testing
Tests added.
Risk
Low. This is only analyzers package.