[rc2] Fix issues with primitive collections inside JSON complex types #36723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
PrimitiveCollections
branch
from
f3e80b8 to
b1244ce
Compare
artl93
approved these changes
Sep 8, 2025
Member
artl93
left a comment
artl93
left a comment
There was a problem hiding this comment.
RC2 - mainline, new scenario for .NET 10.
cincuranet
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks big but product changes are quite minimal.
Continues #36296
Fixes #32493
Description
This fixes some bugs in the handling of primitive/scalar collections within complex JSON types, and adds extensive test coverage.
Customer impact
Before this PR, various queries fail which involve primitive collections (e.g. int/string array) within JSON documents. This is part of the larger complex JSON query we're delivering for 10.
How found
Testing
Regression
No
Testing
Extensive test coverage added
Risk
Low, product changes are relatively minimal and mainly add new code paths.