[rc2] Introduce SqlEngineDbContextOptionsBuilderBase to allow unified registration of extension over SQL Server, Azure SQL and Synapse. #36737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
force-pushed
the
nts
branch
6 times, most recently
from
122c06f to
650c20b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a common base class SqlEngineDbContextOptionsBuilderBase to unify SQL Server, Azure SQL, and Azure Synapse database context option builders, enabling extension methods to work across all three builders.
Key changes:
- Creates a new base class that all SQL engine builders inherit from
- Updates existing builders to inherit from the new base class instead of directly from
RelationalDbContextOptionsBuilder - Modifies the NetTopologySuite extension to use generic constraints for broader compatibility
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SqlEngineDbContextOptionsBuilderBase.cs | New base class providing common functionality for SQL engine builders |
| SqlServerDbContextOptionsBuilder.cs | Updated to inherit from the new base class |
| SqlEngineDbContextOptionsBuilder.cs | Updated to inherit from the new base class |
| AzureSynapseDbContextOptionsBuilder.cs | Updated to inherit from the new base class |
| AzureSqlDbContextOptionsBuilder.cs | Updated to inherit from the new base class |
| SqlServerNetTopologySuiteDbContextOptionsBuilderExtensions.cs | Modified to use generic constraint for broader compatibility |
| SqlServerNetTopologySuiteCodeGeneratorPlugin.cs | Updated method reflection to handle generic method |
| AzureSqlDbContextOptionsExtensionsTest.cs | Added test to verify NetTopologySuite works with UseAzureSql |
src/EFCore.SqlServer.NTS/Scaffolding/Internal/SqlServerNetTopologySuiteCodeGeneratorPlugin.cs
Outdated
Show resolved
Hide resolved
cincuranet
force-pushed
the
nts
branch
2 times, most recently
from
6ee25c9 to
e21403b
Compare
cincuranet
commented
Sep 11, 2025
src/EFCore.SqlServer.NTS/Scaffolding/Internal/SqlServerNetTopologySuiteCodeGeneratorPlugin.cs
Show resolved
Hide resolved
...FCore.SqlServer.NTS/Extensions/SqlServerNetTopologySuiteDbContextOptionsBuilderExtensions.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Sep 12, 2025
AndriySvyryd
changed the title
…tration of extension over SQL Server, Azure SQL and Synapse. * Updates SqlServerNetTopologySuiteDbContextOptionsBuilderExtensions to use it. * Updates SqlServerHierarchyIdDbContextOptionsBuilderExtensions to use it.
artl93
approved these changes
Sep 13, 2025
...FCore.SqlServer.NTS/Extensions/SqlServerNetTopologySuiteDbContextOptionsBuilderExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35244.
Description
I EF 9 we introduced
UseAzureSqlandUseAzureSynapseto allow target translations where these differ from generic SQL Server. These added new builders without common base class making it difficult to have extension methods for registering additional functions on all builders.Customer impact
Customers cannot use i.e.
UseNetTopologySuitewithUseAzureSql.How found
Customer reported.
Regression
Yes. From 9.
Testing
Tests added.
Risk
Low. This only adds base class, no other code changes.