Move PropertyExtensions from Update to Metadata#37932
Merged
AndriySvyryd merged 1 commit intodotnet:mainfrom Mar 16, 2026
Merged
Move PropertyExtensions from Update to Metadata#37932AndriySvyryd merged 1 commit intodotnet:mainfrom
AndriySvyryd merged 1 commit intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR relocates the ConvertToProviderValue internal extension from the update pipeline to the metadata layer so it can be reused by other components (e.g., Cosmos serialization) without referencing the Update.Internal namespace.
Changes:
- Moved
IProperty.ConvertToProviderValue(...)fromMicrosoft.EntityFrameworkCore.Update.InternaltoMicrosoft.EntityFrameworkCore.Metadata.Internal. - Updated EFCore Update and EFCore.Cosmos call sites/usings to reference the new namespace.
- Removed the now-redundant
src/EFCore/Update/Internal/PropertyExtensions.csfile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EFCore/Update/Internal/PropertyExtensions.cs | Removed old location of ConvertToProviderValue. |
| src/EFCore/Update/Internal/InternalUpdateEntryExtensions.cs | Switched to Microsoft.EntityFrameworkCore.Metadata.Internal to keep ConvertToProviderValue usage compiling. |
| src/EFCore/Metadata/Internal/PropertyExtensions.cs | Added ConvertToProviderValue implementation to the metadata internal extensions set. |
| src/EFCore.Cosmos/Query/Internal/CosmosSerializationUtilities.cs | Updated using to the new ConvertToProviderValue namespace for Cosmos serialization. |
You can also share your feedback on Copilot code review. Take the survey.
6 tasks
AndriySvyryd
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #37577 (comment)