Skip to content

Move PropertyExtensions from Update to Metadata#37932

Merged
AndriySvyryd merged 1 commit intodotnet:mainfrom
JoasE:CleanupPropertyExtensions
Mar 16, 2026
Merged

Move PropertyExtensions from Update to Metadata#37932
AndriySvyryd merged 1 commit intodotnet:mainfrom
JoasE:CleanupPropertyExtensions

Conversation

@JoasE
Copy link
Copy Markdown
Contributor

@JoasE JoasE commented Mar 16, 2026

@JoasE JoasE requested a review from a team as a code owner March 16, 2026 10:09
Copilot AI review requested due to automatic review settings March 16, 2026 10:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the ConvertToProviderValue internal extension from the update pipeline to the metadata layer so it can be reused by other components (e.g., Cosmos serialization) without referencing the Update.Internal namespace.

Changes:

  • Moved IProperty.ConvertToProviderValue(...) from Microsoft.EntityFrameworkCore.Update.Internal to Microsoft.EntityFrameworkCore.Metadata.Internal.
  • Updated EFCore Update and EFCore.Cosmos call sites/usings to reference the new namespace.
  • Removed the now-redundant src/EFCore/Update/Internal/PropertyExtensions.cs file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/EFCore/Update/Internal/PropertyExtensions.cs Removed old location of ConvertToProviderValue.
src/EFCore/Update/Internal/InternalUpdateEntryExtensions.cs Switched to Microsoft.EntityFrameworkCore.Metadata.Internal to keep ConvertToProviderValue usage compiling.
src/EFCore/Metadata/Internal/PropertyExtensions.cs Added ConvertToProviderValue implementation to the metadata internal extensions set.
src/EFCore.Cosmos/Query/Internal/CosmosSerializationUtilities.cs Updated using to the new ConvertToProviderValue namespace for Cosmos serialization.

You can also share your feedback on Copilot code review. Take the survey.

@AndriySvyryd AndriySvyryd enabled auto-merge (rebase) March 16, 2026 16:56
@AndriySvyryd AndriySvyryd merged commit 270adac into dotnet:main Mar 16, 2026
14 of 15 checks passed
@JoasE JoasE deleted the CleanupPropertyExtensions branch March 16, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants