Restore sqlite3mc test project using SQLite3MC.PCLRaw.bundle#38015
Merged
AndriySvyryd merged 4 commits intomainfrom Mar 27, 2026
Merged
Restore sqlite3mc test project using SQLite3MC.PCLRaw.bundle#38015AndriySvyryd merged 4 commits intomainfrom
AndriySvyryd merged 4 commits intomainfrom
Conversation
Add Microsoft.Data.Sqlite.sqlite3mc.Tests.csproj using the SQLite3MC.PCLRaw.bundle package (replacement for the deprecated SQLitePCLRaw.bundle_e_sqlite3mc). Update conditional compilation directives, InternalsVisibleTo, solution files, and package versions. Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/3d1bd0d1-7e29-42d2-b610-3df859ae04d7 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/387b831e-9fb8-40e5-9371-469b87dd874b Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
March 26, 2026 18:30
View session
There was a problem hiding this comment.
Pull request overview
Restores Microsoft.Data.Sqlite test coverage for the sqlite3mc (SQLite3MultipleCiphers) native bundle by introducing a new test project wired to SQLite3MC.PCLRaw.bundle, updating conditional compilation, and ensuring the project is included in solution entrypoints.
Changes:
- Add
Microsoft.Data.Sqlite.sqlite3mc.Testsproject targeting both default .NET and .NET Framework, referencingSQLite3MC.PCLRaw.bundleand definingSQLITE3MC. - Introduce centralized versioning for
SQLite3MC.PCLRaw.bundleviaeng/Versions.props+test/Directory.Packages.props. - Update test-framework selection, encryption-related test conditionals, InternalsVisibleTo, and solution/project listings to include sqlite3mc.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.Data.Sqlite.Tests/TestUtilities/SqliteTestFramework.cs | Adds SQLITE3MC option to route the xUnit test framework to the sqlite3mc test assembly. |
| test/Microsoft.Data.Sqlite.Tests/SqliteConnectionTest.cs | Updates encryption-related #if branches to use SQLITE3MC instead of removed E_SQLITE3MC. |
| test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.sqlite3mc.Tests.csproj | New test project referencing SQLite3MC.PCLRaw.bundle and defining SQLITE3MC. |
| test/Directory.Packages.props | Adds centrally managed package version entry for SQLite3MC.PCLRaw.bundle. |
| src/Microsoft.Data.Sqlite.Core/Properties/InternalsVisibleTo.cs | Grants test assembly access to Core internals for sqlite3mc tests. |
| eng/Versions.props | Adds SQLite3MCPCLRawBundleVersion property used for test package versioning. |
| Microsoft.Data.Sqlite.slnf | Updates solution filter to include sqlite3mc tests and remove stale removed projects. |
| EFCore.slnx | Adds the sqlite3mc test project to the main solution manifest. |
…mc.Tests.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/61f804ca-6de6-4180-a3b1-bcf3af5f028c Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
roji
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #36551 removed
Microsoft.Data.Sqlite.e_sqlite3mc.Tests.csprojwhen upgrading to SQLitePCLRaw 3.x becauseSQLitePCLRaw.bundle_e_sqlite3mcwas deprecated. This restores sqlite3mc test coverage using the replacementSQLite3MC.PCLRaw.bundlepackage from the upstream SQLite3MultipleCiphers project, with naming aligned to the new package.Microsoft.Data.Sqlite.sqlite3mc.Tests.csprojreferencingSQLite3MC.PCLRaw.bundlewithSQLITE3MCdefine constant (dropping thee_prefix)SQLite3MCPCLRawBundleVersion(2.3.2) ineng/Versions.props, package entry intest/Directory.Packages.propsSQLITE3MCtoSqliteTestFramework.csassembly attribute chain and encryption-aware#ifdirectives inSqliteConnectionTest.cs; removed staleE_SQLITE3MC,E_SQLCIPHER, andSQLCIPHERreferencesMicrosoft.Data.Sqlite.sqlite3mc.TeststoMicrosoft.Data.Sqlite.CoreEFCore.slnx; cleaned upMicrosoft.Data.Sqlite.slnf(removed stalee_sqlcipher/e_sqlite3mcentries)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.