Add NuGet dependency version bounds for EF Core inter-package references#38114
Merged
AndriySvyryd merged 8 commits intomainfrom Apr 16, 2026
Merged
Add NuGet dependency version bounds for EF Core inter-package references#38114AndriySvyryd merged 8 commits intomainfrom
AndriySvyryd merged 8 commits intomainfrom
Conversation
… same major version Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/ff2d320a-c5bc-4702-9474-118456fa3f9e Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…ackageDependencyUpperBound property Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/13466f2d-2d65-4c9c-b3d0-747244ca9f81 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/13466f2d-2d65-4c9c-b3d0-747244ca9f81 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…/Versions.props Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/f4e8a257-37b6-4ed4-b4b9-7948be16d57e Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…ces and central UseExplicitPackageVersions target Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/16f92744-3ba6-41e4-a2ff-d21d9b3ed385 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…mport order issue Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/c6c7a825-392c-4345-a8d1-5c09b849fd0f Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
April 15, 2026 20:20
View session
…tReference items Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/60788937-58f7-4241-9b1c-6aba77ab6481 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Centralizes and standardizes NuGet dependency version ranges for EF Core inter-package references by moving per-project logic into a single build target and using a shared upper-bound version property.
Changes:
- Adds a computed
NextMajorVersionproperty ineng/Versions.propsfor dependency upper bounds. - Annotates inter-repo
ProjectReferenceitems in packable projects withPackageVersionranges. - Introduces a central
UseExplicitPackageVersionstarget to flowPackageVersionmetadata into nuspec dependency generation.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj | Adds PackageVersion range to the ProjectReference. |
| src/EFCore/EFCore.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Sqlite/EFCore.Sqlite.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Sqlite.NTS/EFCore.Sqlite.NTS.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Sqlite.Core/EFCore.Sqlite.Core.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.SqlServer/EFCore.SqlServer.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.SqlServer.NTS/EFCore.SqlServer.NTS.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.SqlServer.HierarchyId/EFCore.SqlServer.HierarchyId.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Relational/EFCore.Relational.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Proxies/EFCore.Proxies.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.InMemory/EFCore.InMemory.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| src/EFCore.Design/EFCore.Design.csproj | Adds PackageVersion range to the ProjectReference. |
| src/EFCore.Cosmos/EFCore.Cosmos.csproj | Adds PackageVersion ranges to internal ProjectReference items. |
| eng/Versions.props | Introduces computed NextMajorVersion property for version range upper bounds. |
| Directory.Build.targets | Adds central UseExplicitPackageVersions target to propagate explicit ranges into nuspec generation. |
AndriySvyryd
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roji
approved these changes
Apr 16, 2026
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Makes a lot of sense, I've done this in EFCore.PG too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent obscure exception messages caused by mixing packages from different major versions