Revert "Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating"#38120
Merged
cincuranet merged 1 commit intomainfrom Apr 17, 2026
Merged
Revert "Use PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating"#38120cincuranet merged 1 commit intomainfrom
PRAGMA defer_foreign_keys instead of PRAGMA foreign_keys when migrating"#38120cincuranet merged 1 commit intomainfrom
Conversation
…ys` when…" This reverts commit 89b2687.
There was a problem hiding this comment.
Pull request overview
Reverts the SQLite migrations behavior introduced in #35873 by switching back from PRAGMA defer_foreign_keys to toggling PRAGMA foreign_keys during table rebuild migrations, addressing the data-loss scenario described in #37598.
Changes:
- Update SQLite migrations SQL generation to emit
PRAGMA foreign_keys = 0/1with transaction suppression around rebuild drop/rename steps. - Update SQLite migrations SQL generator unit tests to match the new PRAGMA output.
- Update functional migration SQL assertions to include the disable/enable foreign keys PRAGMAs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/EFCore.Sqlite.Core/Migrations/SqliteMigrationsSqlGenerator.cs | Replaces defer_foreign_keys with transaction-suppressed foreign_keys off/on operations around rebuild drop/rename. |
| test/EFCore.Sqlite.FunctionalTests/Migrations/SqliteMigrationsSqlGeneratorTest.cs | Updates expected SQL strings to assert PRAGMA foreign_keys = 0 before drop/rename and = 1 after. |
| test/EFCore.Sqlite.FunctionalTests/Migrations/MigrationsSqliteTest.cs | Updates functional test SQL command expectations to include the new PRAGMA off/on commands. |
roji
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35873.
Fixes #37598.