Update skills#38126
Conversation
There was a problem hiding this comment.
Pull request overview
Updates several agent skill documents to clarify EF Core workflows and internal implementation details.
Changes:
- Refines testing guidance around provider overrides and common pitfalls.
- Adds/updates skill details for query pipeline preprocessing, migrations snapshots, and Cosmos test environment behavior.
- Improves consistency/terminology for “user-invocable” metadata and expands bulk-operations notes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .agents/skills/testing/SKILL.md | Clarifies expectations for provider overrides and adds additional pitfalls/guidance. |
| .agents/skills/query-pipeline/SKILL.md | Expands preprocessing stage description with additional visitor behavior detail. |
| .agents/skills/migrations/SKILL.md | Adds a “Model Snapshot” section with snapshot-specific gotchas. |
| .agents/skills/make-skill/SKILL.md | Aligns checklist terminology to “user-invocable”. |
| .agents/skills/make-custom-agent/SKILL.md | Updates frontmatter field name documentation to “user-invocable”. |
| .agents/skills/cosmos-provider/SKILL.md | Adds notes about Cosmos functional test parallelization and Linux emulator detection. |
| .agents/skills/bulk-operations/SKILL.md | Adds cross-reference to query pipeline skill and a SQLite ExecuteUpdate pitfall. |
AndriySvyryd
force-pushed
the
Upskilling
branch
from
6cfe8ed to
77015ea
Compare
AndriySvyryd
force-pushed
the
Upskilling
branch
from
c367651 to
30e325f
Compare
AndriySvyryd
force-pushed
the
Upskilling
branch
from
30e325f to
21a224d
Compare
AndriySvyryd
force-pushed
the
Upskilling
branch
from
21a224d to
5f98c9d
Compare
AndriySvyryd
force-pushed
the
Upskilling
branch
from
5f98c9d to
c54c1eb
Compare
|
|
||
| ### Formatting | ||
|
|
||
| - Use spaces for indentation (4 spaces) |
There was a problem hiding this comment.
BTW I think pointing to .editorconfig might be a good way to get all our style/formatting, if we don't already do that somewhere.
| - Run tests with project rebuilding enabled (don't use `--no-build`) to ensure code changes are picked up | ||
| - After changing public APIs, run `build.cmd` / `build.sh` to refresh the checked-in `*.baseline.json` files | ||
|
|
||
| #### API baselining |
There was a problem hiding this comment.
FWIW I think this section is a good thing to keep: it's general for the entire codebase, specific to this repo (unless universal guidelines like "avoid unnecessary allocations"), and not something I'd expect the agent (or a human) to just always pick up without a bit of help.
There was a problem hiding this comment.
The agents get it without additional guidance, and we shouldn't contaminate context for the sake of the obsolete contributors 🙃.
There was a problem hiding this comment.
OK, we'll see how it goes :) One crucial thing for me is that this is universal "how this repo functions" guidance that's valid for everything you do (everything that touches public APIs, in any case), so really the typical stuff one finds in instructions. So it makes sense to me, as opposed to very specific "this API does that" etc., which can accumulate ad infinitum.
Based on https://github.com/dotnet/efcore/settings/copilot/memory