Skip to content

Fix flaky ServicePropertyDiscoveryConventionTest.Finds_service_properties_in_hierarchy #38128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 1 commit into from
Apr 17, 2026
+4 −2
Merged

Fix flaky ServicePropertyDiscoveryConventionTest.Finds_service_properties_in_hierarchy #38128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/EFCore.Tests/Metadata/Conventions/ServicePropertyDiscoveryConventionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,10 @@ private abstract class Blog

private class ServicePropertiesContext : DbContext
{
private static readonly InMemoryDatabaseRoot _databaseRoot = new();

protected internal override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
=> optionsBuilder.UseInMemoryDatabase(GetType().Name);
=> optionsBuilder.UseInMemoryDatabase(GetType().Name, _databaseRoot);

public DbSet<PrivateUnmappedBaseSuper> PrivateUnmappedBaseSupers
=> Set<PrivateUnmappedBaseSuper>();
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Tests/ServiceProviderCacheTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ public override void PopulateDebugInfo(IDictionary<string, string> debugInfo)
[ConditionalFact]
public void Service_provider_cache_can_be_cleared()
{
var cache = ServiceProviderCache.Instance;
var cache = new ServiceProviderCache();
var options = new DbContextOptionsBuilder().UseInMemoryDatabase("TestDB").Options;

var provider1 = cache.GetOrAdd(options, providerRequired: false);
Expand Down
Loading