Skip to content

Add .cab/.vbs to FileExtensionSignInfo for VS signing compliance #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesuszarate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add .cab/.vbs to FileExtensionSignInfo for VS signing compliance #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<ItemGroup>
<FileExtensionSignInfo Include=".pyd" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Include=".cat" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Include=".cab" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Include=".vbs" CertificateName="MicrosoftDotNet500" />
Copy link
Copy Markdown
Member

@mmitche mmitche Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says these are 3P...is this the correct cert to use for those 3P scripts?

Copy link
Copy Markdown
Author

@jesuszarate jesuszarate Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — the PR description was stale from an earlier iteration where we used 3PartyScriptsSHA2.

The code intentionally uses MicrosoftDotNet500 because:

  1. FileExtensionSignInfo is global — it applies to ALL .vbs files in the repo, not just the CPython ones
  2. Consistent with the existing .pyd and .cat entries which all use MicrosoftDotNet500
  3. The repo has UseDotNetCertificate=true, so MicrosoftDotNet500 is the standard cert here

I've updated the PR description to match the actual code.


<!-- JS files are customer-modifiable Emscripten toolchain files. They cannot be
Authenticode-signed because modifying a signed file breaks the signature.
Expand Down