Use .Transport instead of _Transport in unversioned manifest name #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All others use .Transport.
lewing
approved these changes
Mar 9, 2023
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Mar 20, 2023
Context: https://github.com/dotnet/runtime/blob/059898f8c0dbea2c6d0ed2ff30bc1b584af6b439/eng/Version.Details.xml#L88-L92 Context: dotnet/emsdk#308 Changes: dotnet/installer@cddf8e6...c373093 Changes: dotnet/runtime@a92ed6e...2aec381 Changes: dotnet/emsdk@4c1f185...25d9f7a Maestro was failing to update with: > darc update-dependencies --id 171040 Looking up build with BAR id 171040 Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23163.4' => '8.0.100-preview.3.23170.5' (from build '20230320.5' of 'https://github.com/dotnet/installer') Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Coherency updates failed for the following dependencies: Unable to update Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 to have coherency with Microsoft.NETCore.App.Ref: https://github.com/dotnet/runtime @ 2aec3816f9bbc0eda3261daa335a05ea0df31b9c does not contain dependency Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 I got the latest dotnet/installer build number from: https://maestro-prod.westus2.cloudapp.azure.com/3074/https:%2F%2Fgithub.com%2Fdotnet%2Finstaller/latest/graph It appears this pack was renamed: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 To become: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport After manually fixing things, I could do: > darc update-dependencies --id 171040 Looking up build with BAR id 171040 Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23163.4' => '8.0.100-preview.3.23170.5' (from build '20230320.5' of 'https://github.com/dotnet/installer') Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Updating 'Microsoft.NETCore.App.Ref': '8.0.0-preview.3.23159.4' => '8.0.0-preview.3.23168.2' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@8.0.100-preview.3.23170.5 Updating 'Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport': '' => '8.0.0-preview.3.23167.1' to ensure coherency with Microsoft.NETCore.App.Ref@8.0.0-preview.3.23159.4 Updating 'Microsoft.NET.ILLink.Tasks': '8.0.0-preview.3.23159.4' => '8.0.0-preview.3.23168.2' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@8.0.100-preview.3.23170.5 Updating 'Microsoft.DotNet.Cecil': '0.11.4-alpha.23156.1' => '0.11.4-alpha.23163.1' to ensure coherency with Microsoft.NET.ILLink.Tasks@8.0.0-preview.3.23159.4 This is nice because we shouldn't have to keep manually fixing this for every future .NET 8 preview.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Mar 21, 2023
Context: https://github.com/dotnet/runtime/blob/059898f8c0dbea2c6d0ed2ff30bc1b584af6b439/eng/Version.Details.xml#L88-L92 Context: dotnet/emsdk#308 Changes: dotnet/installer@cddf8e6...c373093 Changes: dotnet/runtime@a92ed6e...2aec381 Changes: dotnet/emsdk@4c1f185...25d9f7a Maestro was failing to update with: > darc update-dependencies --id 171040 Looking up build with BAR id 171040 Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23163.4' => '8.0.100-preview.3.23170.5' (from build '20230320.5' of 'https://github.com/dotnet/installer') Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Coherency updates failed for the following dependencies: Unable to update Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 to have coherency with Microsoft.NETCore.App.Ref: https://github.com/dotnet/runtime @ 2aec3816f9bbc0eda3261daa335a05ea0df31b9c does not contain dependency Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 I got the latest dotnet/installer build number from: https://maestro-prod.westus2.cloudapp.azure.com/3074/https:%2F%2Fgithub.com%2Fdotnet%2Finstaller/latest/graph It appears this pack was renamed: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.3 To become: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport After manually fixing things, I could do: > darc update-dependencies --id 171040 Looking up build with BAR id 171040 Updating 'Microsoft.Dotnet.Sdk.Internal': '8.0.100-preview.3.23163.4' => '8.0.100-preview.3.23170.5' (from build '20230320.5' of 'https://github.com/dotnet/installer') Checking for coherency updates... Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made. Updating 'Microsoft.NETCore.App.Ref': '8.0.0-preview.3.23159.4' => '8.0.0-preview.3.23168.2' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@8.0.100-preview.3.23170.5 Updating 'Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport': '' => '8.0.0-preview.3.23167.1' to ensure coherency with Microsoft.NETCore.App.Ref@8.0.0-preview.3.23159.4 Updating 'Microsoft.NET.ILLink.Tasks': '8.0.0-preview.3.23159.4' => '8.0.0-preview.3.23168.2' to ensure coherency with Microsoft.Dotnet.Sdk.Internal@8.0.100-preview.3.23170.5 Updating 'Microsoft.DotNet.Cecil': '0.11.4-alpha.23156.1' => '0.11.4-alpha.23163.1' to ensure coherency with Microsoft.NET.ILLink.Tasks@8.0.0-preview.3.23159.4 This is nice because we shouldn't have to keep manually fixing this for every future .NET 8 preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All others use .Transport.