Delete selected libs from cache to shrink size #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete these libs on windows, where we are over the nuget size limit. Context: dotnet#34 (comment) That should affect build times when using [debug sanitizers](https://emscripten.org/docs/debugging/Sanitizers.html), which is not a common scenario I think.
Member
Author
|
We are still too big, 251MB |
Member
Author
|
@lewing that gets us to 250MB. Is it enough or do we need remove more libs? |
Member
Author
|
Now I noticed some of the |
Member
Author
|
@lewing ok, that gets us to 242MB |
lewing
reviewed
Jul 12, 2021
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
I'm assuming this will cause no problems with the default build but have we actually tested it?
Member
|
Ok now that we have a way to ship should we try putting the cache in a separate package and populating it with everything? |
radekdoulik
changed the title
akoeplinger
approved these changes
Jul 13, 2021
akoeplinger
approved these changes
Jul 13, 2021
lewing
approved these changes
Jul 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete these libs on windows, where we are over the nuget size limit.
Context: #34 (comment)
That should affect build times when using
debug sanitizers
which is not used by default builds.
Also remove
mtlibs. We don't support threads yet anyway.