Skip to content

Use Arcade NuSpec helpers#1307

Closed
tmat wants to merge 3 commits intodotnet:darc-master-eeee90b4-00bb-4941-b4e6-fa86c87e7abafrom
tmat:FixNuSpec
Closed

Use Arcade NuSpec helpers#1307
tmat wants to merge 3 commits intodotnet:darc-master-eeee90b4-00bb-4941-b4e6-fa86c87e7abafrom
tmat:FixNuSpec

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Mar 25, 2019

No description provided.

Copy link
Copy Markdown

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll look for the projects with similar overrides in our other 2 repos.

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 25, 2019

@dougbu The CI is failing with some provisioning error:
image

The Windows Release build failure seems to be caused by missing -configuration $(_BuildConfig) argument to eng\scripts\ci-flaky-tests.cmd. The leg builds Release but attempts to run tests from Debug dir.

@dougbu
Copy link
Copy Markdown

dougbu commented Mar 25, 2019

The Windows Release build failure seems to be caused by missing -configuration $(_BuildConfig) argument to eng\scripts\ci-flaky-tests.cmd. The leg builds Release but attempts to run tests from Debug dir.

That's odd. These test legs have been building and testing just fine up to now. Do the new Arcade scripts effectively make the build configuration a mandatory input?

In any case, we're still hitting dotnet/core-eng#5654 for the Ubuntu jobs…


How did you get the extra information beyond the horrible "There as a failure" message?

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Mar 25, 2019

That's odd. These test legs have been building and testing just fine up to now. Do the new Arcade scripts effectively make the build configuration a mandatory input?

IDK. It's always defaulted to Debug. I'm not aware of any change in that. Is it possible that he machines were reused and had the Debug build on them accidentally?

@dougbu
Copy link
Copy Markdown

dougbu commented Mar 26, 2019

Merged these changes manually into darc's branch. Will take this further in #1279. Thanks @tmat❕❕

@dougbu dougbu closed this Mar 26, 2019
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants