Fixes aspnet/Extensions#1503#1504
Merged
davidfowl merged 1 commit intodotnet:masterfrom Apr 23, 2019
ENikS:Issue_1503
Merged
Conversation
davidfowl
approved these changes
Apr 21, 2019
davidfowl
reviewed
Apr 21, 2019
| FakeDisposeCallback callback) : base(callback) | ||
| { | ||
| SingleService = singleService; | ||
| MultipleServices = multipleServices; |
Author
There was a problem hiding this comment.
Author
|
In one of CI tests enumerable is null. Without the null check it fails.
|
Member
Which one? |
Author
|
I am not sure how to get logs for previous build. Do you want me to roll back so you could see it? |
Member
|
Roll back locally and figure out which ones are passing null. These tests run super quickly, and you should be able to run them in VS. |
Author
|
I can't build locally at the moment, I don't have required build tools installed. The solution does not load projects. I can temporary roll back the null check and let it fail CI checks. |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Addresses #bugnumber (in this specific format)
#1503