Skip to content

Conversation

@natemcmaster
Copy link

@natemcmaster natemcmaster commented May 23, 2019

Resolves #1073

This adds support to this repo for building in https://github.com/dotnet/source-build

Changes:

  • Exclude all tests, samples, and benchmarks from building when DotNetBuildFromSource=true
  • Exclude all projects that have a 3rd party dependency. We only need to source-build the assemblies which will end up in ASP.NET Core's shared framework
  • Add CI which runs a script that emulates the source build environment

cc @dseefeld @crummel @Pilchie

@natemcmaster natemcmaster changed the title Add support for building with DotNetBuildFromSource=true Add support for source-build May 23, 2019
@natemcmaster natemcmaster marked this pull request as ready for review May 23, 2019 15:26
@natemcmaster natemcmaster requested review from a team, Tratcher, analogrelay and dougbu as code owners May 23, 2019 15:26
@Tratcher Tratcher removed their request for review May 23, 2019 15:35
</ItemDefinitionGroup>

<ItemGroup Label=".NET Core dependencies">
<ItemGroup Label=".NET team dependencies">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roslyn isn't technically part of .NET Core, but I moved those dependencies into this block.

@natemcmaster natemcmaster merged commit ad4067b into dotnet:master May 23, 2019
@natemcmaster natemcmaster deleted the source-build branch May 23, 2019 23:33
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 17, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aspnet/Extensions to dotnet/source-build

2 participants