Regression in slicing:

[KevinRansom]

Test case tests\fsharpqa\Source\Conformance\Expressions\SyntacticSugar\Slice05.fs fails to build with these errors in the release\fsharp5 branch, it is due to the recent slicing modifications:

Test case disabled here: https://github.com/dotnet/fsharp/blob/master/tests/fsharpqa/Source/Conformance/Expressions/SyntacticSugar/env.lst#L12

artifacts\bin\fsc\Release\net472\fsc -r:artifacts\bin\fsc\Release\net472\FSharp.Core.dll  Slices05.fs
Microsoft (R) F# Compiler version 11.0.0.0 for F# 5.0
Copyright (c) Microsoft Corporation. All Rights Reserved.

Slices05.fs(92,24): error FS0001: This expression was expected to have type
    'double [,]'
but here has type
    'double []'

Slices05.fs(92,27): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a list'

Slices05.fs(92,24): error FS0001: This expression was expected to have type
    'double [,]'
but here has type
    'double []'

Slices05.fs(93,15): error FS0001: This expression was expected to have type
    'int'
but here has type
    'System.DateTime'

Slices05.fs(142,4): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a list'

Slices05.fs(142,20): error FS0001: This expression was expected to have type
    'double []'
but here has type
    ''a [,]'

Slices05.fs(142,20): error FS0001: This expression was expected to have type
    'double []'
but here has type
    'float [,]'

Slices05.fs(145,13): error FS0001: This expression was expected to have type
    'int'
but here has type
    'float'

Slices05.fs(145,20): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a option'

Slices05.fs(146,13): error FS0001: This expression was expected to have type
    'int'
but here has type
    'float'

Slices05.fs(146,17): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a option'

Slices05.fs(146,25): error FS0001: This expression was expected to have type
    'int'
but here has type
    'bool'

Slices05.fs(147,13): error FS0001: This expression was expected to have type
    'int'
but here has type
    'float'

Slices05.fs(147,23): error FS0001: This expression was expected to have type
    'int'
but here has type
    'double option'

Slices05.fs(148,13): error FS0001: This expression was expected to have type
    'int'
but here has type
    'float'

Slices05.fs(148,19): error FS0001: This expression was expected to have type
    'int'
but here has type
    'System.DateTime'

Slices05.fs(148,40): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a option'

Slices05.fs(149,13): error FS0001: This expression was expected to have type
    'int'
but here has type
    'float'

Slices05.fs(149,17): error FS0001: This expression was expected to have type
    'int'
but here has type
    ''a option'

Slices05.fs(149,26): error FS0001: This expression was expected to have type
    'int'
but here has type
    'System.DateTime'

Slices05.fs(149,47): error FS0001: This expression was expected to have type
    'int'
but here has type
    'bool'

[cartermp]

@nelson-wu is this fixed?

[nelson-wu]

@cartermp This will have to be a breaking change that we'll swallow. Uniformizing all array/string slicing methods into extensions is not possible without significant pain, so we're choosing to go the other direction of making them all non-shadowable.

[cartermp]

Sounds good.