Find References doesn't work if #line directives are used

[cartermp]

Take this code (presumably generated):

module File1

#nowarn "25"
#line 1 "foo.fs"
let Thing 1 = 2 

Expected: FindAllReferences on "Thing" reports one usage at the correct location in the given generated file (this is what C# does)

Actual: FindAllRefererences on "Thing" reports one usage on line 1 of File1.fs

---

• Use latest master of the F# codebase
• Navigate to the definition of Option in the FSharp.Core projects
• run Find All References on None

Once it finishes, you'll note that there are many results. However, the first set of results in FSharp.Compiler.Private are the generated pars.fs and lex.fs files are not accurate.

Clicking the first item:

Navigates here:

Maybe this is just a problem for us, but it could mean that any generated files are also giving false positives.

[abelbraaksma]

This raises the question whether "find references" should take line number directives into account (and this may well be the cause of the wrong results here). Those files are full of # 457 "pars.fsy", which is where the "real" definitions are.

[dsyme]

See also #9796