Skip to content

Conversation

@Daniel-Svensson
Copy link
Contributor

Currently it is not possible to load the solution and build with latest Visual Studio 2019 installed since the dotnet sdk version 3.1.402 is not an exact match of the version in specified in global.json (3.1.302)

This pr sets the rollforward option to enable roll forward of sdk version so never versions can be used so that you can open the solution in VS 2019 16.7.5.

change to latestFeature
@vzarytovskii
Copy link
Member

Weren't there issues connected to code signing and using newer sdks?
Will this affect it by any chance? @cartermp @brettfo

@cartermp
Copy link
Contributor

Yes, the signing servers (apparently) don't have up to date tools, sadly. @brettfo would know more about if they got updated or not.

@cartermp
Copy link
Contributor

Normally I'd be fore just jamming this through for a bit but considering how tight it is with shipping....oof.

@KevinRansom
Copy link
Contributor

Please just install 3.1.402 and leave it be. It's side by side and no big deal, unlike the horror show of marshalling internal builds.

@auduchinok
Copy link
Member

Can this one be tagged "Contributor Pain", please? 🙂

@saul
Copy link
Contributor

saul commented Oct 15, 2020

I also permanently have a global.json change in my repo to let me build with 3.1.301 instead of 3.1.302. Surely we don't need this exact patch? Why not set the version in the global.json to 3.1.300, allowing the default rollForward behaviour of latestPatch?

@cartermp
Copy link
Contributor

I agree that it sucks. I personally need to always remember to manually adjust my global.json because VS will not load the codebase here. But this is @KevinRansom and @brettfo's call because our internal servers are garbage and apparently can't update to the latest /shrug

@brettfo
Copy link
Member

brettfo commented Oct 15, 2020

The big issue here is the internal builds. Let me do a full build/test with this change to see if it behaves. If it works we can merge it. ETA on a full build/test run is ~3 hours. I'll return and report when that's done.

@auduchinok
Copy link
Member

@brettfo Could you try running a build with "rollForward": "minor", as proposed in #10130, to see if 3.1.4xx versions could work too?

@brettfo
Copy link
Member

brettfo commented Oct 15, 2020

@auduchinok Sure thing, I'll start one of those, too and we'll see what happens.

@brettfo
Copy link
Member

brettfo commented Oct 15, 2020

Both rollForward values of latestFeature and minor passed the internal build.

@Daniel-Svensson according to the documentation, minor seems to be the more permissive option. Since your branch has a prior commit with minor, could you update to that then as soon as it's green again I'll merge it?

I don't know what your comfort level is with git, but you can rewind one commit with git reset --hard HEAD^ then push with git push --force.

@cartermp
Copy link
Contributor

I did a quick update, we'll see if CI is happy

@cartermp cartermp merged commit 21ea2ba into dotnet:main Oct 16, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants