Microbuild support for F# codebase#1023
Microbuild support for F# codebase#1023OmarTawfik merged 7 commits intodotnet:masterfrom OmarTawfik:microbuild-v2
Conversation
|
What is MicroBuild? Is it open source? Is it the new MSBuild? I noticed this uses https://dotnet.myget.org/gallery/dotnet-buildtools |
|
Looks great ... ship it :-) |
|
@ctaggart Microbuild is the thing that gets us out of the big VS build process internally. It is a step towards removing all of that internal machinery we now have to worry about. For example after this change our internal product build will not have a separate set of project files. Which was always embarrassing but unavoidable. |
…to microbuild-v2
| msbuild vsintegration/fsharp-vsintegration-item-templates-build.proj | ||
| msbuild vsintegration/fsharp-vsintegration-deployment-build.proj | ||
| msbuild vsintegration\fsharp-vsintegration-unittests-build.proj | ||
| msbuild tests/fsharp/FSharp.Tests.fsproj |
There was a problem hiding this comment.
There are a mix of forward and backslashes here
|
@otawfik-ms After this commit incremental builds seem to be broken? On master, when I do It's really important to fix this to enable contributors to be productive in their build+tests |
| <FilesToLocalize Include="$(OutDir)$(AssemblyName).dll"> | ||
| <TranslationFile>$(FSharpSourcesRoot)\..\loc\lcl\{Lang}\$(AssemblyName).dll.lcl</TranslationFile> | ||
| <LciCommentFile>$(FSharpSourcesRoot)\..\loc\lci\$(AssemblyName).dll.lci</LciCommentFile> | ||
| <HasLceComments>false</HasLceComments> |
There was a problem hiding this comment.
Nit: indentation looks off here.
|
@dsyme I believe the failures are related to the recent coreclr changes, not microbuild, which is being fixed now in a separate location. |
Address other comments on #1023
This PR Includes
/cc @Microsoft/fsharp-compiler