Add ConvertToSingleEqualsEqualityExpression code fix#10462
Merged
cartermp merged 4 commits intodotnet:mainfrom Nov 17, 2020
Merged
Add ConvertToSingleEqualsEqualityExpression code fix#10462cartermp merged 4 commits intodotnet:mainfrom
cartermp merged 4 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
This is ready for review |
Contributor
|
Nice! |
KevinRansom
approved these changes
Nov 16, 2020
Contributor
|
What happens if you define Edit: I see, you check for the error message. |
TIHan
approved these changes
Nov 17, 2020
Contributor
Author
|
I'm a clever boy. |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Add ConvertToSingleEqualsEqualityExpression code fix * Fix type
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Add ConvertToSingleEqualsEqualityExpression code fix * Fix type
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Add ConvertToSingleEqualsEqualityExpression code fix * Fix type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a super common beginner mistake.
The quick fix is also correct if the types are both
Nullable, at least as of F# 5.There are several other places where FS00043 can trigger, but this guards on the range of the error only being equal to
==, so it should be safe. A generalized fixer for FS00043 could be interesting, but the errors are rather wide ranging so that is out of scope for now.