Merged
Conversation
Contributor
Author
|
This is ready for review |
KevinRansom
suggested changes
Nov 16, 2020
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
@cartermp, any chance of a test case?
Contributor
Author
|
There's no test harness for these |
TIHan
approved these changes
Nov 17, 2020
Contributor
Author
|
@KevinRansom testing might be possible here, but it might get complicated. Would needs to create a mocking system to verify that certain things trigger. A different approach would be just to factor the logic into a function. But there is so little logic here that it feels like overkill |
KevinRansom
approved these changes
Nov 18, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator:
Keyword:
Surfacing the improved message from #1127 into the code fixer, basically.